Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package-resources-2019-05 to Go SDK #6286

Merged
merged 1 commit into from
Jun 11, 2019
Merged

add package-resources-2019-05 to Go SDK #6286

merged 1 commit into from
Jun 11, 2019

Conversation

jhendrixMSFT
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@jhendrixMSFT jhendrixMSFT self-assigned this Jun 10, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 10, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from b19367d)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4988

@vladbarosan
Copy link

@jhendrixMSFT generation seems to be failing ?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT
Copy link
Member Author

That's the drop generation, maybe @daschult wants to take a look at that.

@jhendrixMSFT jhendrixMSFT merged commit 057c1b0 into Azure:master Jun 11, 2019
@jhendrixMSFT jhendrixMSFT deleted the resource201905 branch June 11, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbarosan vladbarosan vladbarosan approved these changes

@stankovski stankovski Awaiting requested review from stankovski

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhendrixMSFT @AutorestCI @vladbarosan @azuresdkci